[PATCH] aspeed/g5,g4: I2C driver.

[Joel Stanley]

On Wed, Oct 5, 2016 at 10:45 AM, Maxim Sloyko <maxims at google.com> wrote:
>> On 10/03/2016 10:42 PM, maxims at google.com wrote:
>> > From: Maxim Sloyko <maxims at google.com>
>> >
>> > The driver is very limited: only single master mode is supported
>> > and only byte-by-byte synchronous reads and writes are supported,
>> > no Pool Buffers or DMA.
>>
>> I don't think this is a problem for the moment.
>>
>> You should add your SoB here :
>
>
> What is SoB?

Signed-off-by. You can read more about it here:

  http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n420

I recommend having a read of the SubmittingPatches as well as
http://www.denx.de/wiki/U-Boot/Patches. While every rule has it's
exception, it's good background for what is expected.

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches
http://www.denx.de/wiki/U-Boot/Patches
http://www.denx.de/wiki/U-Boot/CodingStyle

>> > +
>> > +static int ast_i2c_probe(struct udevice *dev)
>> > +{
>> > +     struct ast_i2c *i2c_bus = dev_get_priv(dev);
>> > +
>> > +     debug("Enabling I2C%u \n", dev->seq);
>> > +     ast_scu_enable_i2c(dev->seq);
>>
>>
>> I don't see that routine in the u-boot openbmc uses. Which version
>> are you on ?
>
>
> It's in another patch that is also under review. SCU helper functions or
> something like that.

You can make it clear by sending these patches as part of a series.
Make them sequential commits in your local git branch, and then use
git-format-patch to create a sequence of patches.

Your sequence should be bisectable, that is, at each point in history
the tree should build (and hopefully boot). You can check this by
using git rebase interactive's executable flag.

Cheers,

Joel