[PATCH qemu 29/38] aspeed: add a rtc device on I2C bus 0

Andrew Jeffery andrew at aj.id.au
Mon Nov 28 13:09:23 AEDT 2016


On Mon, 2016-11-28 at 12:35 +1030, Andrew Jeffery wrote:
> On Fri, 2016-11-18 at 15:22 +0100, Cédric Le Goater wrote:
> > The palmetto platform has a ds3231 RTC device but not qemu. Let's
> > use
> > a ds1338 instead which provides enough basic RTC features. Only
> > alarms
> > will be missing
> > 
> > Signed-off-by: Cédric Le Goater <clg at kaod.org>
> 
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

With the caveat that we move it to the board file. Evo needs an 'undo
send' option like gmail.

> 
> > ---
> >  hw/arm/aspeed_soc.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
> > index 2aa15d90cc31..d2bc0ba2070d 100644
> > --- a/hw/arm/aspeed_soc.c
> > +++ b/hw/arm/aspeed_soc.c
> > @@ -276,6 +276,10 @@ static void aspeed_soc_realize(DeviceState
> > *dev, Error **errp)
> >      object_property_set_int(OBJECT(dev), 20000, "temperature2",
> > &err);
> >      object_property_set_int(OBJECT(dev), 110000, "temperature3",
> > &err);
> >  
> > +    /* The palmetto platform expects a ds3231 RTC but a ds1338 is
> > +     * enough to provide basic RTC features. Alarms will be
> > missing */
> > +    i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&s->i2c), 0),
> > "ds1338", 0x68);
> > +
> >      /* FMC */
> >      fmc_num_cs = aspeed_fmc_get_cs(s, &err);
> >      if (err) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161128/1631375a/attachment.sig>


More information about the openbmc mailing list