Fw: [PATCH] aspeed-bmc-opp-palmetto: Add GPIO hogs to devicetree

[Andrew Jeffery]

On Tue, 2016-11-22 at 10:48 +1030, Joel Stanley wrote:
> On Tue, Nov 22, 2016 at 5:25 AM, Christopher Bostic
> > <christopher.lee.bostic at gmail.com> wrote:
> > > Have you been testing on a Palmetto using an OpenBMC build? If so the
> > > request should still fail as the patch is applied in the OpenBMC kernel
> > > build. All I'm proposing here is we move it from OpenBMC into the
> > > Aspeed kernel tree.
> > 
> > Yes I have been testing on Palmetto using OpenBMC builds.  The H6
> > pin reports as busy when I request it so for now I have a workaround
> > to bypass the gpio interface. 

Ah, you should've piped up! We could have saved you the annoyance of
the work-around.

> >  All the other pins I grab via the normal
> > dts gpio devm_gpio_get interfaces.   Once the H6 hog can be removed,
> > assuming no other code needs it,

No code explicitly needs the hogs, they're purely a kernel solution to
configure the GPIOs to boot the host.

> >  I can remove my workaround in
> > the OpenFSI code.
> 
> I suggest you add a patch to your tree that removes the hog from the
> palmetto dts file. Now that we have a driver that owns the hardware
> the hog can be removed.

Yes, definitely. Chris: I can push a revised version of that patch into
gerrit if you're interested, though I don't think that we should apply
it until we have OpenFSI in the kernel and integrated into OpenBMC.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161122/7ee7638d/attachment.sig>