[PATCH qemu 30/38] wdt: Add Aspeed watchdog device model

Joel Stanley joel at jms.id.au
Tue Nov 22 00:23:56 AEDT 2016


On Mon, Nov 21, 2016 at 11:33 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> +
>> +#define WDT_IO_REGION_SIZE      0x1000
>> +
>> +#define WDT_STATUS              0x00
>> +#define WDT_RELOAD_VALUE        0x04
>> +#define WDT_RESTART             0x08
>> +#define WDT_CTRL                0x0C
>> +#define WDT_TIMEOUT_STATUS      0x10
>> +#define WDT_TIMEOUT_CLEAR       0x14
>> +#define WDT_RESET_WDITH         0x18
>
>
> May be we should reduce the size of WDT_IO_REGION_SIZE to 0x20
> to instantiate the three watchdog of the Aspeed AST2500 with
> one class ?

Yep I agree. This is how the kernel driver does it too.

Cheers,

Joel


More information about the openbmc mailing list