[PATCH qemu 09/38] aspeed/scu: fix SCU region size

[Cédric Le Goater]

On 11/21/2016 08:26 AM, Joel Stanley wrote:
> On Sat, Nov 19, 2016 at 12:51 AM, Cédric Le Goater <clg at kaod.org> wrote:
>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> 
> Reviewed-by: Joel Stanley <joel at jms.id.au>
> 
>> ---
>>  hw/misc/aspeed_scu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
>> index 34e86385d837..95022d3607ad 100644
>> --- a/hw/misc/aspeed_scu.c
>> +++ b/hw/misc/aspeed_scu.c
>> @@ -86,7 +86,7 @@
>>  #define BMC_DEV_ID           TO_REG(0x1A4)
>>
>>  #define PROT_KEY_UNLOCK 0x1688A8A8
>> -#define SCU_IO_REGION_SIZE 0x20000
>> +#define SCU_IO_REGION_SIZE 0x1000
>>
> 
> The last register is at 0x1A4. Do we want to use that as the size?

That is a good remark. 

The Aspeed specs define address space ranges for each controller
but the full window is not covered by the registers. So when 
you go beyond the last register, the HW loops back on the first 
after while. Holes are filled with 0xffffffff or 0x0. 

I suppose restricting the window to the last register is the 
best option. Event if it is possible, going beyond is a guest 
error anyhow.

Thanks,

C. 

> 
>>  static const uint32_t ast2400_a0_resets[ASPEED_SCU_NR_REGS] = {
>>       [SYS_RST_CTRL]    = 0xFFCFFEDCU,
>> --
>> 2.7.4
>>
>> _______________________________________________
>> openbmc mailing list
>> openbmc at lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/openbmc