[PATCH linux 00/19] FSI device driver introduction

Joel Stanley joel at jms.id.au
Mon Nov 21 15:51:52 AEDT 2016


Hello Chris,

On Mon, Nov 21, 2016 at 1:10 PM,  <christopher.lee.bostic at gmail.com> wrote:

> Chris Bostic (7):
>   drivers/fsi: Set up links for slave communication
>   drivers/fsi: Set slave SMODE to init communication
>   drivers/fsi: Add master unscan
>   drivers/fsi: Add GPIO based FSI master
>   drivers/fsi: Add client driver register utilities
>   drivers/fsi: Add SCOM FSI client device driver
>   drivers/fsi: Add Mailbox FSI client device driver
>
> Jeremy Kerr (12):
>   fsi: Add empty fsi bus definitions
>   fsi: Add device & driver definitions
>   fsi: add driver to device matches
>   fsi: Add fsi master definition
>   fsi: Add fake master driver

>   fsi: enable debug

Drop this debug patch.

>   fsi: Add slave definition
>   fsi: Add empty master scan
>   fsi: Add crc4 helpers
>   fsi: Implement slave initialisation
>   fsi: scan slaves & register devices
>   fsi: Add device read/write/peek functions

A few housekeeping issues:

You're missing patch 1, 4 and 14 from the series.

Please resend with the full series and add cc linux-kernel at vger.kernel.org.

You should base your series on an upstream tree. I suggest 4.9-rc1.
This will mean dropping the patch to the Witherspoon dts which is not
upstream.

Finally, make the subjects consistent: pick either drivers/fsi or fsi
for the entire series.

Cheers,

Joel

>
>  .../devicetree/bindings/fsi/fsi-master-gpio.txt    |  21 +
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts      |   9 +
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts   |   9 +
>  drivers/Kconfig                                    |   2 +
>  drivers/Makefile                                   |   1 +
>  drivers/fsi/Kconfig                                |  41 ++
>  drivers/fsi/Makefile                               |   6 +
>  drivers/fsi/fsi-core.c                             | 533 +++++++++++++++++++
>  drivers/fsi/fsi-master-fake.c                      |  95 ++++
>  drivers/fsi/fsi-master-gpio.c                      | 578 +++++++++++++++++++++
>  drivers/fsi/fsi-master.h                           |  62 +++
>  drivers/fsi/fsi-mbx.c                              | 196 +++++++
>  drivers/fsi/fsi-scom.c                             | 225 ++++++++
>  include/linux/fsi.h                                |  73 +++
>  14 files changed, 1851 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fsi/fsi-master-gpio.txt
>  create mode 100644 drivers/fsi/Kconfig
>  create mode 100644 drivers/fsi/Makefile
>  create mode 100644 drivers/fsi/fsi-core.c
>  create mode 100644 drivers/fsi/fsi-master-fake.c
>  create mode 100644 drivers/fsi/fsi-master-gpio.c
>  create mode 100644 drivers/fsi/fsi-master.h
>  create mode 100644 drivers/fsi/fsi-mbx.c
>  create mode 100644 drivers/fsi/fsi-scom.c
>  create mode 100644 include/linux/fsi.h
>
> --
> 1.8.2.2
>


More information about the openbmc mailing list