[PATCH linux 1/2] ARM: dts: aspeed: zaius: Add 1-wire buses

Joel Stanley joel at jms.id.au
Thu Nov 17 15:55:41 AEDT 2016


On Thu, Nov 17, 2016 at 9:59 AM, Xo Wang <xow at google.com> wrote:
> Add device-tree bindings to instantiate GPIO-based 1-wire buses. These
> go to headers for DS18B20 thermal sensors.
>
> Signed-off-by: Xo Wang <xow at google.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index b52e45e..3d997d9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -20,6 +20,26 @@
>                 reg = <0x80000000 0x40000000>;
>         };
>
> +       onewire0 {

I wasn't sure if we should use a cell index: onewire at 0, onewire at 1, ...
The binding suggests yes, but the convention is usually to make the
cell index correspond to the reg property, and we don't have one one
here.

Lets merge it as is.

Reviewed-by: Joel Stanley <joel at jms.id.au>


> +               compatible = "w1-gpio";
> +               gpios = <&gpio ASPEED_GPIO(H, 0) GPIO_ACTIVE_HIGH>;
> +       };
> +
> +       onewire1 {
> +               compatible = "w1-gpio";
> +               gpios = <&gpio ASPEED_GPIO(H, 1) GPIO_ACTIVE_HIGH>;
> +       };
> +
> +       onewire2 {
> +               compatible = "w1-gpio";
> +               gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_HIGH>;
> +       };
> +
> +       onewire3 {
> +               compatible = "w1-gpio";
> +               gpios = <&gpio ASPEED_GPIO(H, 3) GPIO_ACTIVE_HIGH>;
> +       };
> +
>         leds {
>                 compatible = "gpio-leds";
>
> --
> 2.8.0.rc3.226.g39d4020
>
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc


More information about the openbmc mailing list