[PATCH linux v4 0/3] Seven segment display support

[Joel Stanley]

Hello Jagha,

On Wed, Nov 16, 2016 at 7:07 AM, Jaghathiswari Rankappagounder
Natarajan <jaghu at google.com> wrote:
> Hi Joel,
>
> Could you please provide feedback for this driver.

You have not addressed all of the comments from Rick in v4 of your
patches. The first thing I noticed is he pointed out you need to
separate out the device tree documentation from the code. I stopped
reading at this point.

Please go back and re-read the previous review and ensure your patches
address all comments.

Cheers,

Joel


>
> Thanks,
> Jagha
>
>
> On Wed, Nov 2, 2016 at 1:17 PM, Jaghathiswari Rankappagounder Natarajan
> <jaghu at google.com> wrote:
>>
>> This patchset includes:
>>
>> Character device driver which implements the user-space API for letting a
>> user
>> write to two 7-segment displays including any conversion methods necessary
>> to map the user input to two 7-segment displays.
>>
>> Platform device driver which provides an API for displaying on two
>> 7-segment
>> displays, and implements the required bit-banging. The hardware assumed is
>> 74HC164 wired to two 7-segment displays.
>>
>> Adding clock, data and clear signal lines in the devicetree to control
>> seven segment display on zaius platform.
>>
>> A changelog between versions is included in the individual patches. Please
>> provide feedback.
>>
>> Thanks,
>> Jagha
>>
>> Jaghathiswari Rankappagounder Natarajan (3):
>>   drivers: misc: Character device driver for seven segment display
>>   drivers: misc: Platform driver for seven segment display support
>>   devicetree: Add devicetree changes to support seven segment display on
>>     zaius
>>
>>  .../bindings/misc/seven_segment_gpio.txt           |  23 +++
>>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts         |   8 +
>>  drivers/misc/Kconfig                               |  16 ++
>>  drivers/misc/Makefile                              |   2 +
>>  drivers/misc/seven_seg_disp.c                      | 198
>> ++++++++++++++++++
>>  drivers/misc/seven_seg_disp.h                      |  35 ++++
>>  drivers/misc/seven_seg_gpio.c                      | 225
>> +++++++++++++++++++++
>>  7 files changed, 507 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/misc/seven_segment_gpio.txt
>>  create mode 100644 drivers/misc/seven_seg_disp.c
>>  create mode 100644 drivers/misc/seven_seg_disp.h
>>  create mode 100644 drivers/misc/seven_seg_gpio.c
>>
>> --
>> 2.8.0.rc3.226.g39d4020
>>
>