[PATCH linux dev-4.7 7/8] ipmi: maintain a request expiry list

[Cédric Le Goater]

On 11/03/2016 10:06 AM, Cédric Le Goater wrote:
> On 11/03/2016 01:26 AM, Cyril Bur wrote:
>> On Wed, 2016-10-26 at 08:57 +0200, Cédric Le Goater wrote:
>>> Regarding the response expiration handling, the IPMI spec says :
>>>
>>>    The BMC must not return a given response once the corresponding
>>>    Request-to-Response interval has passed. The BMC can ensure this
>>>    by maintaining its own internal list of outstanding requests through
>>>    the interface. The BMC could age and expire the entries in the list
>>>    by expiring the entries at an interval that is somewhat shorter than
>>>    the specified Request-to-Response interval....
>>>
>>> To handle such case, we maintain list of received requests using the
>>> seq number of the BT message to identify them. The list is updated
>>> each time a request is received and a response is sent. The
>>> expirationof the reponses is handled at each updates but also 
>>> with a timer.
>>>
>>
>> I agree that the BMC kernel is most logical place to do this, at the
>> moment btbridged does attempt something similar no?
>>
>>
>> Should we patch btbridged to not? Should I least remove duplicated
>> logic? 
> 
> yes probably. Let's see what mainline says about it first. 
> The patch has a minor flaw: struct ipmi_request should include 
> the NetFn and Command values. Corey might ask for a resend.

So it seems this patch is raising more questions than solving 
problems. Let's leave it aside for the moment and keep the list
in btbridged.

Thanks,

C.