[linux dev-4.7 PATCH 4/4] arm: aspeed: Remove SPI controller hacks

Andrew Jeffery andrew at aj.id.au
Fri Nov 4 15:05:28 AEDT 2016


On Fri, 2016-11-04 at 13:57 +1030, Joel Stanley wrote:
> On Fri, Nov 4, 2016 at 1:38 PM, Andrew Jeffery <andrew at aj.id.au> wrote:
> > 
> > > 
> > > -     /* SCU setup
> > > -      *  - GPIOC{4,5,6} are FUNC_MODE{0,1,2}. These nets are
> > > -      *    connected to the Ethernet phy and to ensure the correct
> > > -      *    operation they all need to be in GPIO mode (SCU90[0] = 0)
> > > -      *    and then pulled down
> > > -      */
> > Did you intend to remove this? It's still relevant and useful.
> Yeah I did.
> 
> It's still an accurate description of the hardware. But it's not
> describing the register writes below. It's in the device tree now.

Hah, fair point.

In that case:

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

> 
> Cheers,
> 
> Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161104/e0d2b656/attachment.sig>


More information about the openbmc mailing list