[linux dev-4.7 PATCH 4/4] arm: aspeed: Remove SPI controller hacks

Andrew Jeffery andrew at aj.id.au
Fri Nov 4 14:08:44 AEDT 2016


On Fri, 2016-11-04 at 09:00 +1030, Joel Stanley wrote:
> The spi-nor driver aspeed-smc configures these registers now.
> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>  arch/arm/mach-aspeed/aspeed.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/arm/mach-aspeed/aspeed.c b/arch/arm/mach-aspeed/aspeed.c
> index 46e711ca275c..f81dccbcd2eb 100644
> --- a/arch/arm/mach-aspeed/aspeed.c
> +++ b/arch/arm/mach-aspeed/aspeed.c
> @@ -42,19 +42,9 @@ static void __init do_common_setup(void)
>  	/* Enable LPC FWH cycles, Enable LPC to AHB bridge */
>  	writel(0x00000500, AST_IO(AST_BASE_LPC | 0x80));
>  
> -	/* Flash controller */
> -	writel(0x00000003, AST_IO(AST_BASE_SPI | 0x00));
> -	writel(0x00002404, AST_IO(AST_BASE_SPI | 0x04));
> -
>  	/* Set UART routing */
>  	writel(0x00000000, AST_IO(AST_BASE_LPC | 0x9c));
>  
> -	/* SCU setup
> -	 *  - GPIOC{4,5,6} are FUNC_MODE{0,1,2}. These nets are
> -	 *    connected to the Ethernet phy and to ensure the correct
> -	 *    operation they all need to be in GPIO mode (SCU90[0] = 0)
> -	 *    and then pulled down
> -	 */

Did you intend to remove this? It's still relevant and useful.

>  	/* TODO: This should go in the GPIO driver device tree bindings */
>  	writel(0x01C000FF, AST_IO(AST_BASE_SCU | 0x88));
>  	writel(0xC1C000FF, AST_IO(AST_BASE_SCU | 0x8c));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161104/70cad783/attachment.sig>


More information about the openbmc mailing list