[PATCH linux dev-4.7 4/8] ipmi: add an Aspeed BT IPMI BMC driver

Cédric Le Goater clg at kaod.org
Wed Nov 2 18:08:22 AEDT 2016


On 11/02/2016 01:00 AM, Joel Stanley wrote:
> Hey Cedric,
> 
> On Wed, Oct 26, 2016 at 5:27 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> Backport from mainline of the main IPMI BMC driver patch plus fixes :
>>
>>  - commit d94655b405ba ("ipmi/bt-bmc: remove redundant return value
>>    check of platform_get_resource()")
>>  - commit a3e6061bad62 ("ipmi/bt-bmc: add a dependency on
>>    ARCH_ASPEED")
>>  - commit 1a377a79211a ("ipmi: Fix ioremap error handling in bt-bmc")
>>  - commit 54f9c4d0778b ("ipmi: add an Aspeed BT IPMI BMC driver")
> 
> It has just occurred to me that this driver is written for the iBT
> hardware in the Aspeed, and we also have the BT hardware.

This is true. one is IPMI compliant, the other follows H8S/2168.
 
> If we were to write a driver for the BT hardware it would clash with
> this one. In particular the compatible string and the character device
> name.
> 
> I propose sending a patch to upstream before the release of 4.9 that
> changes the chardev name to ipmi-ibt-host and changing the comaptible
> string to ast2400-ibt-bmc.
> 
> What do you think?

I can include the change in the patchset I will send for the expiry list 
and see how Corey reacts. 

C.




More information about the openbmc mailing list