[PATCH skeleton v2 03/11] fix info memory leak

Stewart Smith stewart at linux.vnet.ibm.com
Wed Mar 23 16:49:39 AEDT 2016


OpenBMC Patches <openbmc-patches at stwcx.xyz> writes:
> diff --git a/objects/info.c b/objects/info.c
> index ab2d98c..76c17d9 100644
> --- a/objects/info.c
> +++ b/objects/info.c
> @@ -145,7 +145,7 @@ int get_hdd_status(void)
>  
>      g_read_tmp[2]=g_read_bytes[2];
>      g_read_tmp[3]=g_read_bytes[3];
> -
> +    close(fd);
>  }

Your commit message doesn't match this change. Here you fix a *file
descriptor* leak, not a memory leak.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the openbmc mailing list