[PATCH 2/2] hwmon/adm1275: Support sense resistor parameter from dt

Jeremy Kerr jk at ozlabs.org
Tue Mar 22 12:46:01 AEDT 2016


Hi Joel,

> +adm1275 temperature sensor
> +--------------------------
> +
> +Required property:
> +
> + - compatible: "adi,adm1278"
> + - reg: i2c device address 
> +
> +Optional property:
> +
> +- sense-resistor: external sense resistor value in milliOhms

This is just a multiplier, right? We shouldn't need to care what the
hardware implementation is, just that we do need to scale the value.

So, how about:

  Optional property:

  - multiplier: multiplier to be applied to sensor readings (eg, to
                account for a sense resistor on the device input)

Other than that, all looks good to me.

Cheers,


Jeremy


More information about the openbmc mailing list