[PATCH u-boot] MAC needs to be stopped after starting

Cyril Bur cyrilbur at gmail.com
Tue Mar 15 14:28:21 AEDT 2016


On Fri, 11 Mar 2016 08:20:43 -0600
OpenBMC Patches <openbmc-patches at stwcx.xyz> wrote:

It would be nice if github informed us that the correct action has been taken
here.

I happened to check pull/3 and notice that it was closed, I'm sure if favour of
Miltons more robust fix.

Happy with that but it's just not clear by simply following the mailing list.

> We found that u-boot network was corrupting kernel memory.
> This is because aspeednic_init is called at startup,
> but if the u-boot network is not used, the network driver
> is not cleaned up.  This fix is a temporary hack and just calls
> the halt function after the init. This driver needs to be
> reworked to not start network initially and use set_hwaddr hook
> to setup MAC address.  
> 
> Signed-off-by: Norman James <nkskjames at gmail.com>
> 
> <!-- Reviewable:start -->
> ---
> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/openbmc/u-boot/3)
> <!-- Reviewable:end -->
> 
> 
> https://github.com/openbmc/u-boot/pull/3
> 
> Norman James (1):
>   MAC needs to be stopped after starting
> 
>  drivers/net/aspeednic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 



More information about the openbmc mailing list