[PATCH linux v2 2/2] hwmon: Hide error message in OCC hwmon driver

Joel Stanley joel at jms.id.au
Thu Mar 10 13:58:12 AEDT 2016


Hey Adam,

On Wed, Mar 9, 2016 at 10:08 AM, Cyril Bur <cyrilbur at gmail.com> wrote:
> Patch looks good. I'm not super sure the "ERROR:" string is needed in front of
> all the messages, I suspect it will be obvious. However I'm far more in favour
> of consistency ("ERROR:" everywhere) and you've done that so its fine with me.

These are good fixes. In addition to the fixes you have made and
Cyrils suggested improvements, you could perhaps better handle the
case where the host is powered off by detecting a lack of any i2c
response and aborting early.

Cheers,

Joel


More information about the openbmc mailing list