[PATCH openbmc-test-automation] PreTag Test Automation Basic Code clean-up needed #9

OpenBMC Patches openbmc-patches at stwcx.xyz
Thu Jun 30 17:50:33 AEST 2016


From: George Keishing <gkeishin at in.ibm.com>

---
 tests/security/test_ssl.robot  | 2 --
 tests/test_association.robot   | 1 -
 tests/test_bootpolicy.robot    | 2 --
 tests/test_eventlog.robot      | 2 +-
 tests/test_fan.robot           | 4 ++++
 tests/test_power_restore.robot | 2 --
 6 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index 7bcab5e..57d7d5e 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -5,8 +5,6 @@ Suite Teardown    Delete All Sessions
 Resource          ../../lib/rest_client.robot
 Resource          ../../lib/resource.txt
 
-Library           RequestsLibrary.RequestsKeywords
-
 *** Test Cases ***
 Test SSL Connection
     [Documentation]     This testcase is for testing the SSL connection to the
diff --git a/tests/test_association.robot b/tests/test_association.robot
index b4422d5..5931afe 100755
--- a/tests/test_association.robot
+++ b/tests/test_association.robot
@@ -4,7 +4,6 @@ Documentation          This suite is used for testing eventlog association.
 Resource        ../lib/rest_client.robot
 Resource        ../lib/utils.robot
 
-Library         BuiltIn
 Library         Collections
 Library         SSHLibrary
 
diff --git a/tests/test_bootpolicy.robot b/tests/test_bootpolicy.robot
index b6528c7..19637eb 100644
--- a/tests/test_bootpolicy.robot
+++ b/tests/test_bootpolicy.robot
@@ -11,8 +11,6 @@ Suite Teardown  Close All Connections
 
 
 *** Variables ***
-${SYSTEM_SHUTDOWN_TIME}       ${5}
-${WAIT_FOR_POWER_OPERATION}   30sec
 
 *** Test Cases ***
 
diff --git a/tests/test_eventlog.robot b/tests/test_eventlog.robot
index 660d449..d6666d5 100644
--- a/tests/test_eventlog.robot
+++ b/tests/test_eventlog.robot
@@ -117,7 +117,7 @@ deleting log after obmc-phosphor-event.service restart
     ${resp} =    openbmc post request     ${deluri}    data=${NIL}
     should be equal as strings      ${resp.status_code}     ${HTTP_OK}
 
-makeing new log after obmc-phosphor-event.service restart
+making new log after obmc-phosphor-event.service restart
     [Documentation]     This is for testing event creation after the
     ...                 event service is restarted.
     Open Connection And Log In
diff --git a/tests/test_fan.robot b/tests/test_fan.robot
index 2f593b5..dfb9502 100644
--- a/tests/test_fan.robot
+++ b/tests/test_fan.robot
@@ -4,3 +4,7 @@ Suite Teardown    Delete All Sessions
 Resource          ../lib/rest_client.robot
 
 *** Test Cases ***
+Test place holder dummy
+   [Documentation]   Dummy Test case. We can't have an empty test case in
+   ...               the testcase directory.
+   Log    This is a dummy test case.. Ignore
diff --git a/tests/test_power_restore.robot b/tests/test_power_restore.robot
index d0e27d5..15fff11 100644
--- a/tests/test_power_restore.robot
+++ b/tests/test_power_restore.robot
@@ -10,8 +10,6 @@ Resource        ../lib/utils.robot
 
 Library         SSHLibrary
 
-[Documentation]       Data Driven Tests
-
 
 ***test cases***
 
-- 
2.9.0




More information about the openbmc mailing list