[PATCH openbmc v5 10/11] u-boot: Upgrade AST2400 machines to 2016.15 tree.
Patrick Williams
patrick at stwcx.xyz
Sat Jun 25 06:09:31 AEST 2016
On Fri, Jun 24, 2016 at 12:20:50PM +0930, Joel Stanley wrote:
> On Fri, Jun 24, 2016 at 6:10 AM, OpenBMC Patches
> <openbmc-patches at stwcx.xyz> wrote:
> > From: Patrick Williams <patrick at stwcx.xyz>
> > @@ -4,10 +4,10 @@
> >
> > PREFERRED_PROVIDER_virtual/kernel ?= "linux-obmc"
> > PREFERRED_VERSION_linux-obmc ?= "4.4+git%"
> > -PREFERRED_VERSION_u-boot ?= "v2013.07+git%"
> > -PREFERRED_VERSION_u-boot-fw-utils ?= "v2013.07+git%"
> > +PREFERRED_VERSION_u-boot ?= "v2016.05+git%"
> > +PREFERRED_VERSION_u-boot-fw-utils ?= "v2016.05+git%"
>
> Should this be the branch name? The branch is called v2016.05-aspeed-openbmc.
>
No. Package level is the right thing here. We have our override of the
global u-boot package and in there is where we specify the branch. This
is a buildroot pointer to get to that package.
> > -UBOOT_MACHINE ?= "palmetto_config"
> > +UBOOT_MACHINE ?= "ast_g4_config"
>
> As I mentioned in my status update, I didn't do the best job of naming
> the defconfigs. ast_g4_config is for ast2400 systems that use NC-SI,
> which means it's no good for firestone or the facebook machines.
>
> Do you want me to rename the config ast_g4_ncsi_config? Or leave it
> for now, and we can clean it up once the u-boot tree is in order.
>
> I would lean towards leaving it for now as once u-boot is cleaned up
> to use the Kconfig system, we can have the yocto machines select the
> option they require.
>
> > UBOOT_ENTRYPOINT ?= "0x40001000"
> > UBOOT_LOADADDRESS ?= "0x40001000"
>
>
> > diff --git a/meta-openbmc-machines/meta-openpower/meta-ibm/meta-firestone/conf/machine/firestone.conf b/meta-openbmc-machines/meta-openpower/meta-ibm/meta-firestone/conf/machine/firestone.conf
> > index 42f2d29..fa0d35e 100644
> > --- a/meta-openbmc-machines/meta-openpower/meta-ibm/meta-firestone/conf/machine/firestone.conf
> > +++ b/meta-openbmc-machines/meta-openpower/meta-ibm/meta-firestone/conf/machine/firestone.conf
> > @@ -5,7 +5,7 @@ require conf/machine/include/ast2400.inc
> > require conf/machine/include/obmc-bsp-common.inc
> > require conf/machine/include/ibm.inc
> >
> > -UBOOT_MACHINE_firestone = "palmetto_config"
> > +UBOOT_MACHINE_firestone = "ast_g4_config"
>
> As above; firestone uses a dedicated phy instead of NC-SI. Machines
> won't have network if they update to this.
>
> I can add add a new system to u-boot, or I can send a patch that hacks
> at the machine.
>
Lets do one config with the dedicated and one without. I don't care on
the name.
Is there going to be trouble with NC-SI if we use a different NC-SI
chip? Witherspoon has a different chip than Garrison, but I don't know
what u-boot cares at that level.
If it is all just "ncsi" and "no-ncsi" lets name them that way.
Otherwise, we probably should continue to use something like "palmetto"
as that is the reference board that has that specific NC-SI chip class.
--
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160624/19a0e203/attachment.sig>
More information about the openbmc
mailing list