[PATCH linux 3/4] ftgmac100: Add devicetree option for the Aspeed g5 register interface

[Joel Stanley]

Hey Cedric,

On Fri, Jun 24, 2016 at 2:39 AM, Cédric Le Goater <clg at kaod.org> wrote:
>> So, given that there always has been fixes from Aspeed on the driver in
>> u-boot (see below), it seems that these EDO bits have been wrong since
>> the beginning in Linux.
>>
>> I am wondering what how this was working. We should probably contact
>> Aspeed to have some clarification.
>
> Aspeed said that they have a different design than Faraday and we should
> be using :
>
>         #define FTGMAC100_TXDES0_EDOTR          (1 << 30)
>         #define FTGMAC100_RXDES0_EDORR          (1 << 30)
>
> for all boards : ast2400 *and* ast2500.
>
> I gave it a try on a palmetto and indeed, network works fine with the
> Aspeed EDO{T,R}R bits.

Nice investigation. Thank you for doing that.

I have sent a revised patch for the kernel that incorporates Andrew's
work with your findings.

 https://lists.ozlabs.org/pipermail/openbmc/2016-June/003876.html
 https://lists.ozlabs.org/pipermail/openbmc/2016-June/003877.html

Please review and add your tags, and I'll update the branch with the fixes.

If you want to do something similar for u-boot then please go ahead.
Otherwise I'll do it on Monday.

Cheers,

Joel