[u-boot 0/3] Add minimal ast2400 support

[Cédric Le Goater]

On 06/21/2016 01:39 PM, Joel Stanley wrote:
> On Tue, Jun 21, 2016 at 5:41 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> On 06/21/2016 09:29 AM, Joel Stanley wrote:
>>> Hello OpenBMC u-boot hackers!
>>>
>>> This series adds minimal ast2400 support to the v2016.05 tag of u-boot. It
>>> applies on top of the v2016.05-ast2500 tree that Cedric created for the
>>> ast2500-evb.
>>>
>>> It is a copy of the code from the Aspeed SDK with minimal changes to get it to
>>> compile in a modern u-boot tree.
>>>
>>> Pending review, I will add this to a branch called v2016.05-aspeed-openbmc in
>>> the openbmc u-boot repository and point all of our 2400 and 2500 systems at
>>> this branch.
>>
>> Looks good to me.
> 
> Great. I pushed it along with some other cleanups to my tree:
> 
>  https://github.com/shenki/u-boot/tree/v2016.05-aspeed-openbmc

Thanks for doing this. It was important to have a common branch for both
ast2400 and ast2500 to start cleaning up.

> I'll boot test it on a palmetto, ast2500evb, and witherspoon tomorrow
> and then move openbmc to use this branch.

Tested on palmetto and ast2500evb. It boots fine the OpenBmc image and 
network is ok after boot on both. However network does not work on the
ast2400 in uboot. This needs digging.

>>
>>> Joel Stanley (3):
>>>   ast-g5: Simplify config and board file
>>
>> The configuration system has changed and a lot more can be configured
>> through Kconfig now. I think the aspeed code relies a bit too much on
>> #define still.
> 
> Yeah, the config files are still very messy. Before we add any more
> platforms we should move our existing ones to Kconfig.
> 
>>
>>>   ARM: AST2400: add support
>>>   arm: aspeed: Remove cpu directory
>>
>> We could to the same for G5.
> 
> Done.
> 
>>
>> G5 also has this hunk which needs investigation :
> 
> Eww. Can you please open a bug on openbmc/u-boot?

done.

	https://github.com/openbmc/u-boot/issues/8

Thanks,

C.

>> --- a/arch/arm/cpu/arm1176/start.S
>> +++ b/arch/arm/cpu/arm1176/start.S
>> @@ -35,7 +35,6 @@
>>   */
>>
>>         .globl reset
>> -
>>  reset:
>>         /*
>>          * set the cpu to SVC32 mode
>> @@ -82,8 +81,9 @@ cpu_init_crit:
>>         orr     r0, r0, #0x00001000     @ set bit 12 (I) I-Cache
>>
>>         /* Prepare to disable the MMU */
>> -       adr     r2, mmu_disable_phys
>> -       sub     r2, r2, #(CONFIG_SYS_PHY_UBOOT_BASE - CONFIG_SYS_TEXT_BASE)
>> +       /* Ryan TODO ....*/
>> +#      adr     r2, mmu_disable_phys
>> +#      sub     r2, r2, #(CONFIG_SYS_PHY_UBOOT_BASE - CONFIG_SYS_TEXT_BASE)
>>         b       mmu_disable
>>
>>         .align 5
>> @@ -92,7 +92,7 @@ mmu_disable:
>>         mcr     p15, 0, r0, c1, c0, 0
>>         nop
>>         nop
>> -       mov     pc, r2
>> +#      mov     pc, r2
>>  mmu_disable_phys:
>>
>>  #endif