[u-boot 0/3] Add minimal ast2400 support

[Cédric Le Goater]

On 06/21/2016 09:29 AM, Joel Stanley wrote:
> Hello OpenBMC u-boot hackers!
> 
> This series adds minimal ast2400 support to the v2016.05 tag of u-boot. It
> applies on top of the v2016.05-ast2500 tree that Cedric created for the
> ast2500-evb.
> 
> It is a copy of the code from the Aspeed SDK with minimal changes to get it to
> compile in a modern u-boot tree.
> 
> Pending review, I will add this to a branch called v2016.05-aspeed-openbmc in
> the openbmc u-boot repository and point all of our 2400 and 2500 systems at
> this branch.

Looks good to me. 

> Joel Stanley (3):
>   ast-g5: Simplify config and board file

The configuration system has changed and a lot more can be configured 
through Kconfig now. I think the aspeed code relies a bit too much on 
#define still. 

>   ARM: AST2400: add support
>   arm: aspeed: Remove cpu directory

We could to the same for G5.

G5 also has this hunk which needs investigation :

--- a/arch/arm/cpu/arm1176/start.S
+++ b/arch/arm/cpu/arm1176/start.S
@@ -35,7 +35,6 @@
  */
 
        .globl reset
-
 reset:
        /*
         * set the cpu to SVC32 mode
@@ -82,8 +81,9 @@ cpu_init_crit:
        orr     r0, r0, #0x00001000     @ set bit 12 (I) I-Cache
 
        /* Prepare to disable the MMU */
-       adr     r2, mmu_disable_phys
-       sub     r2, r2, #(CONFIG_SYS_PHY_UBOOT_BASE - CONFIG_SYS_TEXT_BASE)
+       /* Ryan TODO ....*/
+#      adr     r2, mmu_disable_phys
+#      sub     r2, r2, #(CONFIG_SYS_PHY_UBOOT_BASE - CONFIG_SYS_TEXT_BASE)
        b       mmu_disable
 
        .align 5
@@ -92,7 +92,7 @@ mmu_disable:
        mcr     p15, 0, r0, c1, c0, 0
        nop
        nop
-       mov     pc, r2
+#      mov     pc, r2
 mmu_disable_phys:
 
 #endif

Thanks

C.





> 
>  arch/arm/Kconfig                                   |    4 +
>  .../arm/include/asm/arch-aspeed/ast2400_platform.h |   84 +
>  board/aspeed/ast-g4/Kconfig                        |   21 +
>  board/aspeed/ast-g4/Makefile                       |    1 +
>  board/aspeed/ast-g4/ast-g4.c                       |  113 +
>  board/aspeed/ast-g4/platform.S                     | 3092 ++++++++++++++++++++
>  board/aspeed/ast-g5/ast-g5.c                       |    1 -
>  configs/ast_g4_defconfig                           |    9 +
>  include/configs/ast-g4.h                           |  187 ++
>  include/configs/ast-g5.h                           |   85 +-
>  10 files changed, 3522 insertions(+), 75 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-aspeed/ast2400_platform.h
>  create mode 100644 board/aspeed/ast-g4/Kconfig
>  create mode 100644 board/aspeed/ast-g4/Makefile
>  create mode 100644 board/aspeed/ast-g4/ast-g4.c
>  create mode 100644 board/aspeed/ast-g4/platform.S
>  create mode 100644 configs/ast_g4_defconfig
>  create mode 100644 include/configs/ast-g4.h
>