[u-boot 1/3] ast-g5: Simplify config and board file

[Joel Stanley]

On Tue, Jun 21, 2016 at 5:28 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> -#define CONFIG_SYS_LOAD_ADDR         0x83000000      /* default load address */
>> +#define CONFIG_SYS_LOAD_ADDR 0x83000000      /* default load address */
>>
>>  #define CONFIG_BOOTARGS              "console=ttyS0,115200n8 ramdisk_size=16384 root=/dev/ram rw init=/linuxrc mem=80M"
>
> May be we could change these CONFIG_BOOTARGS to a OpenBMC one, which is more
> standard :
>
>         "console=ttyS4,115200n8 root=/dev/ram rw"
>
> That can be other patch.

Agreed, I'll make that change.

Actually, the Google guys have already made that change and I pushed
it to the tree openbmc/u-boot#2016.05-ast2500.

 https://github.com/openbmc/u-boot/commit/3ec6f724873fb197d3226b5c9f4e81621ff978cf

I will ensure that patch is in the branch I create.

>>  /* ------------------------------------------------------------------------- */
>> @@ -183,48 +156,12 @@
>>  #define CONFIG_PHY_ADDR                      0
>>  #define CONFIG_PHY_REALTEK
>>  #endif
>> -
>>  #ifdef CONFIG_CMD_NET
>> -/* #define CONFIG_MAC_NUM    2 */
>>  #define CONFIG_FTGMAC100
>>  #define CONFIG_PHY_MAX_ADDR  32      /* this comes from <linux/phy.h> */
>> -/* #define CONFIG_SYS_DISCOVER_PHY */
>>  #define CONFIG_FTGMAC100_EGIGA
>
> So the aspeednic is only in the witherspoon branch ? (which is better if so)

Currently, yes. I will pull the aspeednic driver into our branch and
create a separate machine for witherspoon. That way we can continue
using the same branch while Gavin and I develop a u-boot ncsi stack.

Thanks for the review.

Cheers,

Joel