[PATCH openbmc v4 08/10] initfs: update: add check for image size vs mtd size
OpenBMC Patches
openbmc-patches at stwcx.xyz
Wed Jun 15 11:40:29 AEST 2016
From: "Milton D. Miller II" <miltonm at us.ibm.com>
The flashcp command will check the file size vs the partition size,
so add a check when looking at images.
Use stat -L -c "%s" to get the file size, and compare it to the mtd
size from the sysfs size attribute.
If this check is suppressed the enforcement is left to flashcp.
Signed-off-by: Milton Miller <miltonm at us.ibm.com>
---
.../obmc-phosphor-initfs/files/obmc-update.sh | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-update.sh b/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-update.sh
index 09348b6..7344438 100755
--- a/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-update.sh
+++ b/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-update.sh
@@ -48,6 +48,14 @@ childmtds() {
done
}
+toobig() {
+ if test $(stat -L -c "%s" "$1") -gt $(cat /sys/class/mtd/"$2"/size)
+ then
+ return 0
+ fi
+ return 1
+}
+
findmtd() {
m=$(grep -xl "$1" /sys/class/mtd/*/name)
m=${m%/name}
@@ -85,6 +93,7 @@ doclean=
dosave=y
dorestore=y
toram=
+checksize=y
checkmount=y
whitelist=/run/initramfs/whitelist
@@ -114,6 +123,9 @@ do
--no-flash)
doflash=
shift ;;
+ --ignore-size)
+ checksize=
+ shift ;;
--ignore-mount)
checkmount=
doflash=
@@ -161,6 +173,11 @@ do
echo 1>&2 "Unable to find mtd partiton for ${f##*/}."
exit 1
fi
+ if test -n "$checksize" && toobig "$f" "$m"
+ then
+ echo 1>&1 "Image ${f##*/} too big for $m."
+ exit 1
+ fi
for s in $m $(childmtds $m)
do
if test -n "$checkmount" && mtdismounted $s
--
2.8.4
More information about the openbmc
mailing list