[PATCH linux v4 1/4] drivers/fsi: Initial stubs for FSI device driver.

Andrew Jeffery andrew at aj.id.au
Fri Jul 29 11:20:55 AEST 2016


On Thu, 2016-07-28 at 20:43 +0200, Cédric Le Goater wrote:
> On 07/28/2016 08:14 PM, christopher.lee.bostic at gmail.com wrote:
> > 
> > From: Christopher Bostic <cbostic at us.ibm.com>
> > 
> > Signed-off-by: Christopher Bostic <cbostic at us.ibm.com>
> > ---
> > 
> > Changes to this patch based on reviewer feedback
> > 
> > V2:
> > - Removed enums in fsiinit.h and replaced with #defines
> > - Added proper file copyright and license headers
> > - Added certificate of origin
> > - Removed version string
> > - Replace kobject with struct device in struct fsidd
> > - Suggestions to implement standard bus_type will be implemented in
> >   later patches
> > 
> > V3:
> > - Removed white space
> > - Suggestions to add Kconfig will be added in follow on patches
> > 
> > V4:
> > - Removed blank line at end of fsiinit.c
> It would be nice to add a [patch 0/4] explaining 'briefly' what 
> FSI is. This is really an IBM 'thing' that people don't know about. 

I agree. `git format-patch --cover-letter ...` should be used for any
series longer than a single patch. It provides the place for the
blurb Cédric asks for.

Cheers,

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160729/86adb441/attachment.sig>


More information about the openbmc mailing list