[PATCH linux] Fix the incorrect debounce setting on power button

[Patrick Williams]

On Fri, Jul 22, 2016 at 02:10:17AM +0930, Joel Stanley wrote:
> Hello,
> 
> On Thu, Jul 21, 2016 at 8:31 PM, OpenBMC Patches
> <openbmc-patches at stwcx.xyz> wrote:
> > From: johnhcwang <hsienchiang at gmail.com>
> >
> > PCLK divider selection is decided by SCU08[25:23] and the value is 011b
> > on Barreleye.
> > That means PCLK should be H-PLL/8=384MHz/8=48MHz, but the current
> > debounce timer value was computed by 24MHz.
> > So the correct value should be 20ms*48000000/1000=EA600h
> 
> Thanks for the patch. I noticed this is against our dev-4.4 tree,
> which is no longer maintained.
> 
> Given you're looking at barreleye, I assume you are using the v1.0
> release of OpenBMC?
> 
> Patrick, if I do a new dev-4.4 tag with this fix, would it be queued
> up for a v1.0.x release?

I can do that.  It is up to Foxconn to let us know what fixes they'd
like put into a v1.0.x release at this point.

> 
> Cheers,
> 
> Joel
> 
> > Signed-off-by: johnhcwang <hsienchiang at gmail.com>
> > ---
> >  arch/arm/mach-aspeed/aspeed.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-aspeed/aspeed.c b/arch/arm/mach-aspeed/aspeed.c
> > index 11d8a61..fadbbb6 100755
> > --- a/arch/arm/mach-aspeed/aspeed.c
> > +++ b/arch/arm/mach-aspeed/aspeed.c
> > @@ -159,9 +159,9 @@ static void __init do_barreleye_setup(void)
> >         writel(0x00000001, AST_IO(AST_BASE_GPIO | 0x48));
> >         writel(0x00000001, AST_IO(AST_BASE_GPIO | 0x4C));
> >
> > -       /* Set debounce timer to 480000 cycles, with a pclk of 24MHz,
> > +       /* Set debounce timer to 480000 cycles, with a pclk of 48MHz,
> >          * corresponds to 20 ms. This time was found by experimentation */
> > -       writel(0x00075300, AST_IO(AST_BASE_GPIO | 0x58));
> > +       writel(0x000EA600, AST_IO(AST_BASE_GPIO | 0x58));
> >  }
> >
> >  static void __init do_palmetto_setup(void)
> > --
> > 2.9.0
> >
> >
> > _______________________________________________
> > openbmc mailing list
> > openbmc at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/openbmc

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160721/0c62054a/attachment.sig>