[PATCH 10/10] net/farady: Mask PHY interrupt with NCSI mode

Gavin Shan gwshan at linux.vnet.ibm.com
Sun Jul 3 15:40:15 AEST 2016

On Thu, Jun 30, 2016 at 11:36:07PM +0930, Joel Stanley wrote:
>On Thu, Jun 30, 2016 at 7:57 PM, Gavin Shan <gwshan at linux.vnet.ibm.com> wrote:
>>         if (pdev->dev.of_node &&
>>             (of_get_property(pdev->dev.of_node, "use-nc-si", NULL) ||
>>             of_get_property(pdev->dev.of_node, "use-ncsi", NULL))) {
>As before, lets pick single a property and stick with it.

The reason why I used two strings is the change is still fine on those BMCs
where "ncsi-nc-si" is supported only. Joel, I personal prefer "use-ncsi".
Lets adjust it later in device-tree.


More information about the openbmc mailing list