[PATCH skeleton v2] Refactored LED control dbus methods

Benjamin Herrenschmidt benh at au1.ibm.com
Thu Jan 28 10:25:29 AEDT 2016


On Wed, 2016-01-27 at 14:54 +1100, Cyril Bur wrote:
> +const char *power_ctrl = "brightness";
> > +const char *blink_ctrl = "trigger";
> > +const char *duty_on   = "delay_on";
> > +const char *duty_off  = "delay_off";
> 
> Why can't these be #defined?

Ugh ? A const string is better, more strongly typed and guarantees
there is going to be only one (though compilers are smart these days).

Cheers,
Ben.



More information about the openbmc mailing list