[PATCH 2/2] arm/aspeed: Enable VUART driver

Joel Stanley joel at jms.id.au
Sat Jan 30 13:23:17 AEDT 2016


On Fri, Jan 29, 2016 at 3:25 PM, Jeremy Kerr <jk at ozlabs.org> wrote:
> This change makes use of the new VUART device driver. We need a separate
> compatible property for the VUART node, and a fix for the interrupt
> definitions. We also change the SCU setup to notify host firmware that the
> VUART is available.
>
> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
> ---
>  arch/arm/boot/dts/ast2400.dtsi    | 7 ++++---
>  arch/arm/configs/aspeed_defconfig | 3 +++
>  arch/arm/mach-aspeed/aspeed.c     | 2 +-
>  3 files changed, 8 insertions(+), 4 deletions(-)
>

> diff --git a/arch/arm/mach-aspeed/aspeed.c b/arch/arm/mach-aspeed/aspeed.c
> index cdab46b..2feb161 100644
> --- a/arch/arm/mach-aspeed/aspeed.c
> +++ b/arch/arm/mach-aspeed/aspeed.c
> @@ -123,7 +123,7 @@ static void __init do_common_setup(void)
>
>         /* Setup scratch registers */
>         writel(0x00000042, AST_IO(AST_BASE_LPC | 0x170));
> -       writel(0x00004000, AST_IO(AST_BASE_LPC | 0x174));
> +       writel(0x00008000, AST_IO(AST_BASE_LPC | 0x174));

Perhaps a comment here to indicate what the values in the register indicate.

Where do we define what the scratch registers mean?

>  }
>
>  static void __init do_barreleye_setup(void)


More information about the openbmc mailing list