[PATCH phosphor-host-ipmid v7] Add get/set ipmid command support with correct DBUS property handling.
stewart at linux.vnet.ibm.com
Tue Jan 12 16:45:09 AEDT 2016
OpenBMC Patches <openbmc-patches at stwcx.xyz> writes:
> 1) Add support for IPMI get/set boot option command.
> a) boot options stored in dbus property.
> b) IPMI get boot option command get boot option from the dbus
> c) IPMI set boot option coomand set boot option to the dbus
> 2) Two methods to handle the dbus property set and get:
> a) dbus_set_property()
> b) dbus_get_property()
> 3) The property is stored as a 10 character strings which representsd 5-byte information.
> 4) ipmid set method is registered and implemented since petitboot will use it to clear the boot options.
> 5) Get service name via object mapper
> a) The connection name is got via objectmapper.
> b) The method used to get the connection name is object_mapper_get_connection().
> c) dbus_get_property/dbus_set_property will get the connection name via the above method instead of hard coding.
> 6) Error code are properly handled.
> 7) Use sprinf/sscanf for int/string conversion.
> a) Instead of reinventing the wheel by defining methods converting int to string, use sprintf/sscanf should be a more clean and robust way.
> 8) Fix issues addressed by the community.
> a) change malloc heap to stack local variable.
> b) Fix multi line comment style from "//" to "/**/".
> c) Add defines for return codes.
> d) Add more comments.
Please read https://www.kernel.org/doc/Documentation/SubmittingPatches
sections 2, 3, 6, 8, 9, 11, 12, 13, 14 and 15 - which all generally
apply to most projects, and certainly are what others who've reviewed
this series (along with myself) look for.
OPAL Architect, IBM.
More information about the openbmc