[PATCH phosphor-host-ipmid v7] Add get/set boot option ipmid command support with correct DBUS property handling.

Sam Mendoza-Jonas sam at mendozajonas.com
Tue Jan 12 13:02:28 AEDT 2016


Hi,

On Mon, Jan 11, 2016 at 06:50:39PM -0600, OpenBMC Patches wrote:
> From: shgoupf <shgoupf at cn.ibm.com>

(snip)

> -        memcpy(response, &buf, *data_len);
> +        uint64_t return_value;
> +        sscanf(buf, "%PRIx64", &return_value);

I just noticed this change from the previous version; have you tested
this? I believe you need to use the PRIx64 specifier like this:

	sscanf(buf, "%" PRIx64, &return_value);

Where PRIx64 is not within the quotes. Do you get an error when you
build this?

Regards,
Sam Mendoza-Jonas



More information about the openbmc mailing list