[PATCH phosphor-host-ipmid v5] Add get/set boot option ipmid command support with correct DBUS property handling.

[Stewart Smith]

Peng Fei BG Gou <shgoupf at cn.ibm.com> writes:

> Thanks Stewart for your comments.
> Please see my answers starting with >>>> [pengfei]:

It'd be better to configure your mail client to do proper internet style
replies, although I see "X-Mailer: Lotus Domino Web Server Build
V851SAAS_12072015_FP3 December 17, 2015" - which likely means you are
using IBM Verse. IBM Verse is not suitable for open source work - you'll
have to get an IBM LTC IMAP account (which has its own problems on still
reyling on some IBM mail infrastructure) or sign up for GMail.

Although, since you're in China, signing up for something like GMail may
be problematic.

>     > --- a/chassishandler.h
>     > +++ b/chassishandler.h
>     > @@ -3,21 +3,39 @@
>     > 
>     > #include <stdint.h>
>     > 
>     > +// TODO: Petitboot requires 8 bytes of response
>     > +// however only 5 of them are used. The remaining
>     > +// 3 bytes are not used in petitboot and the value
>     > +// of them are all zero.
>     
>     where? why? why will it never change?
>     
>     
>     >>>> [pengfei]: Currently the target of this patch is to add
>     support for what the current petitboot requires, so I don't
>     believe we need to do things beyond that with this patch.

What if we update petitboot? AT least historically, BMC and host
firmware have not always been updated in tandem.

-- 
Stewart Smith
OPAL Architect, IBM.