[PATCH v3 5/6] openbmc: Lift mkfs opts to variables and use OVERRIDES capability

[Andrew Jeffery]

On Wed, 2016-02-24 at 00:09 +0000, Milton Miller II wrote:
> 
> 
> Andrew Jeffery <andrew at aj.id.au> wrote:
> >Subject: [PATCH v3 5/6] openbmc: Lift mkfs opts to variables and use
> >OVERRIDES capability
> >
> >Moves the ext4-specific mkfs options out to configuration variables.
> >OVERLAY_MKFS_OPTS can be overridden using the usual bitbake OVERRIDES
> >mechanism, where the override postfix is 'rwfs-${OVERLAY_BASETYPE}',
> >e.g. rwfs-ext4.
> >
> >Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> >---
> > .../classes/obmc-phosphor-image_types_uboot.bbclass | 12
> >+++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> >diff --git
> >a/meta-phosphor/classes/obmc-phosphor-image_types_uboot.bbclass
> >b/meta-phosphor/classes/obmc-phosphor-image_types_uboot.bbclass
> >index 96193a3..f75cdc1 100644
> >--- a/meta-phosphor/classes/obmc-phosphor-image_types_uboot.bbclass
> >+++ b/meta-phosphor/classes/obmc-phosphor-image_types_uboot.bbclass
> >@@ -23,6 +23,12 @@ FLASH_ROFS_OFFSET ?= "4864"
> > FLASH_RWFS_OFFSET ?= "28672"
> > RWFS_SIZE ?= "4096"
> > 
> >+# Avoid setting 'ext4' or 'jffs2' in OVERRIDES as this breaks the
> >build. Prefix
> >+# with 'rwfs-' to avoid option collisions.
> >+DISTROOVERRIDES .= ":rwfs-${OVERLAY_BASETYPE}"
> 
> or more simply comment the reason it breaks:
> 
> # OVERRIDES of just the file system type are reserved for 
> # the primary image type.  Prefix with rwfs- for the overlay.

Gah, got a link to the documentation? I concluded this through blood,
sweat and bitbake, but didn't have anything formal to clear it up.

Andrew

> 
> otherwise,
> Acked-by: Milton Miller <miltonm at us.ibm.com>
> 
> milton
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160224/881e1fb8/attachment.sig>