[PATCH linux v2] mtd: spi-nor: aspeed-smc: Use io string accessors to fifo

Joel Stanley joel at jms.id.au
Mon Feb 22 16:31:15 AEDT 2016


On Mon, Feb 22, 2016 at 11:27 AM, Andrew Jeffery <andrew at aj.id.au> wrote:
> I think the change of direction in the {to,from}_fifo implementations
> improves the readability. Thanks!
>
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>
>
> On Fri, 2016-02-19 at 13:10 -0600, OpenBMC Patches wrote:
>> From: "Milton D. Miller II" <miltonm at us.ibm.com>
>>
>> Make and use new routines to access the fifo when in user mode.
>> Instead of using memcpy_fromio, base the new routines on the io
>> port string accessors.
>>

>>
>> Signed-off-by: Milton Miller <miltonm at us.ibm.com>

Thanks Milton. We will take this into our tree so we can use the flash driver.

Separately to that we need to work out what our solution will be to
get a working driver upstream.

>> ---
>>  drivers/mtd/spi-nor/Kconfig      |   2 +
>>  drivers/mtd/spi-nor/aspeed-smc.c | 120
>> ++++++++++++++++++++++++++++++++++++---
>>  2 files changed, 113 insertions(+), 9 deletions(-)


More information about the openbmc mailing list