[PATCH skeleton 2/2] Makefile changes to fix LED build failures in bitbake

[Daniel Axtens]

OpenBMC Patches <openbmc-patches at stwcx.xyz> writes:

> From: vishwa <vishwanath at in.ibm.com>
>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e787990..1a8e88e 100755
> --- a/Makefile
> +++ b/Makefile
> @@ -6,7 +6,7 @@ OBJS2   = progress.o ast-sf-ctrl.o libflash.o libffs.o arm_io.o
>  OBJS3   = obj/progress.o obj/ast-sf-ctrl.o obj/libflash.o obj/libffs.o obj/arm_io.o
>  INCLUDES=$(shell pkg-config --cflags gio-unix-2.0 glib-2.0) -Iincludes -Iobjects/pflash -I.
>  LIBS=$(shell pkg-config --libs gio-unix-2.0 glib-2.0) -Llib -lopenbmc_intf
> -INC_FLAG += $(shell pkg-config --cflags --libs libsystemd) -I. -O2
> +INCLUDES += $(shell pkg-config --cflags --libs libsystemd) -I. -O2

Would this be better as $(CFLAGS) rather than $(INCLUDES)?

Regards,
Daniel

>  LIB_FLAG += $(shell pkg-config  --libs libsystemd)
>  
>  %.o: interfaces/%.c 
> @@ -42,7 +42,7 @@ led_controller: led_controller.o gpio.o object_mapper.o libopenbmc_intf
>  	$(CC) -o bin/$@.exe obj/gpio.o obj/led_controller.o obj/object_mapper.o $(LDFLAGS) $(LIBS)
>  
>  led_controller_new: led_controller_new.o
> -	$(CC) $(INC_FLAG) -o bin/$@.exe obj/led_controller_new.o $(LDFLAGS) $(LIBS) $(LIB_FLAG)
> +	$(CC) -o bin/$@.exe obj/led_controller_new.o $(LDFLAGS) $(LIB_FLAG)
>  
>  button_power: button_power_obj.o gpio.o object_mapper.o libopenbmc_intf
>  	$(CC) -o bin/$@.exe obj/button_power_obj.o obj/gpio.o obj/object_mapper.o $(LDFLAGS) $(LIBS)
> -- 
> 2.6.4
>
>
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc