[PATCH v2 0/5] LPC/MBOX work
Cyril Bur
cyrilbur at gmail.com
Thu Dec 22 17:06:05 AEDT 2016
Hi all,
Sending this v2 a little prematurely but it will be good to have some eyes on it.
I haven't been able to boot the host with this as there are quite a few caveats.
First of all hostboot expects the flash at a very specific place on the host LPC
bus per platform. This creates problems when a machine of a certain type has a
flash chip of a different size as to what it should have. This renders the UNMAP
ioctl() somewhat useless. We should be able to compensate for this in userspace,
which is good since I don't want any of these caveats worked around in the kernel.
I have had some troubles with regmap_write() but it is possible the bug has been
fixed. I will test in the coming days and confirm.
I have attempted to address all the review comments:
- Use of regmap
- Open counts to avoid opening by different processes
- Style fixes
- Move mbox to drivers/mailbox
- Extra descriptions
Notable exception that I haven't gotten around to but will happily do once we
get to a working state is preventing mutiple threads from writing mbox registers
at once
Thanks,
Cyril
Cyril Bur (5):
ARM: dts: aspeed: Reserve BMC ram for host to BMC communication
ARM: dts: aspeed: Put the lpc_ctrl under lpc_host node for regmap
ARM: dts: aspeed: Move mbox under lpc_host node
drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver
drivers/misc: Add aspeed ast2400/ast2500 lpc controlling driver
arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 6 +
arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 6 +
arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts | 6 +
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 7 +
arch/arm/boot/dts/aspeed-g4.dtsi | 36 +++
drivers/mailbox/Kconfig | 9 +
drivers/mailbox/Makefile | 3 +
drivers/mailbox/aspeed-mbox.c | 354 +++++++++++++++++++++++++
drivers/misc/Kconfig | 9 +
drivers/misc/Makefile | 1 +
drivers/misc/aspeed-lpc-ctrl.c | 292 ++++++++++++++++++++
include/uapi/linux/aspeed-lpc-ctrl.h | 25 ++
include/uapi/linux/aspeed-mbox.h | 23 ++
13 files changed, 777 insertions(+)
create mode 100644 drivers/mailbox/aspeed-mbox.c
create mode 100644 drivers/misc/aspeed-lpc-ctrl.c
create mode 100644 include/uapi/linux/aspeed-lpc-ctrl.h
create mode 100644 include/uapi/linux/aspeed-mbox.h
--
2.11.0
More information about the openbmc
mailing list