[PATCH linux 6/7] arm: aspeed: dts: Add I2C POWER8 OCC compatible string

Andrew Jeffery andrew at aj.id.au
Tue Dec 20 11:55:51 AEDT 2016


On Fri, 2016-12-16 at 14:36 -0600, eajames.ibm at gmail.com wrote:
> > From: "Edward A. James" <eajames at us.ibm.com>
> 
> Add devicetree entry to probe up the POWER8 OCC driver on I2C bus.
> 
> > Signed-off-by: Edward A. James <eajames at us.ibm.com>
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index cc5fcf2..1a775f5 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -20,6 +20,15 @@
> >  	};
>  };
>  
> +&i2c3 {
> > +	status = "okay";
> +
> > +	occ at 50 {
> > +		compatible = "ibm,p8-occ-i2c";
> > +		reg = <0x50>;
> > +	};
> +};
> +
>  &uart5 {
> >  	status = "okay";
>  };

This patch should be split out into a separate series that gets sent to
the Aspeed maintainer (Joel).

However, it looks good. Given it's been completely re-written I'd drop
my signed-off-by. Instead you can add:

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161220/bf17a2bc/attachment.sig>


More information about the openbmc mailing list