[RFC PATCH linux v6 7/9] arm: aspeed: dts: Fix OCC compatible strings

Andrew Jeffery andrew at aj.id.au
Tue Dec 13 14:18:16 AEDT 2016


On Tue, 2016-11-29 at 17:04 -0600, eajames.ibm at gmail.com wrote:
> > From: "Edward A. James" <eajames at us.ibm.com>
> 
> > Signed-off-by: Edward A. James <eajames at us.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 4 ++--
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 4 ++--
>  arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts  | 4 ++--
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts  | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> index bedff97..42f734e 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> @@ -110,12 +110,12 @@
> >  	status = "okay";
>  
> >  	occ at 50 {
> > -		compatible = "ibm,occ-i2c";
> +		compatible = "ibm,occ-p8-i2c";

We will need to give this some thought with respect to the naming
consistency mentioned in previous patches.

Also, this patch should be re-worked so it's relevant for upstream
which doesn't have the existing OCC driver.

Other than that I think this is fine.

Andrew

>  		reg = <0x50>;
> >  	};
>  
> >  	occ at 51 {
> > -		compatible = "ibm,occ-i2c";
> > +		compatible = "ibm,occ-p8-i2c";
> >  		reg = <0x51>;
> >  	};
>  };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index bbe09fc..df12e6b 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -122,7 +122,7 @@
>  
> >  	// turismo
> >  	occ at 50 {
> > -		compatible = "ibm,occ-i2c";
> > +		compatible = "ibm,occ-p8-i2c";
> >  		reg = <0x50>;
> >  	};
>  
> @@ -137,7 +137,7 @@
>  
> >  	// turismo
> >  	occ at 50 {
> > -		compatible = "ibm,occ-i2c";
> > +		compatible = "ibm,occ-p8-i2c";
> >  		reg = <0x50>;
> >  	};
>  
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts b/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts
> index 7737c09..38d51bf 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts
> @@ -63,7 +63,7 @@
> >  	status = "okay";
>  
> >  	occ at 50 {
> > -		compatible = "ibm,occ-i2c";
> > +		compatible = "ibm,occ-p8-i2c";
> >  		reg = <0x50>;
> >  	};
>  };
> @@ -72,7 +72,7 @@
> >  	status = "okay";
>  
> >  	occ at 50 {
> > -		compatible = "ibm,occ-i2c";
> > +		compatible = "ibm,occ-p8-i2c";
> >  		reg = <0x50>;
> >  	};
>  };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index e17158f..8d9aaa3 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -120,7 +120,7 @@
> >  	status = "okay";
>  
> >  	occ at 50 {
> > -		compatible = "ibm,occ-i2c";
> > +		compatible = "ibm,occ-p8-i2c";
> >  		reg = <0x50>;
> >  	};
>  };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161213/76ff4025/attachment.sig>


More information about the openbmc mailing list