[PATCH linux 1/3] ARM: dts: aspeed: Update palmetto device tree

[Joel Stanley]

Hi Cyril,

On Fri, Dec 9, 2016 at 4:43 PM, Cyril Bur <cyrilbur at gmail.com> wrote:
> Palmettos have 512mb of ram. There is always framebuffer memory at the
> top of ram.
>
> This patch also reserves BMC ram for host to BMC communication.
>
> Signed-off-by: Cyril Bur <cyrilbur at gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 25 ++++++++++++++++++++++++-
>  arch/arm/boot/dts/aspeed-g4.dtsi              |  6 ++++++
>  2 files changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index acaceda2..e810ae7 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -17,7 +17,30 @@
>         };
>
>         memory {
> -               reg = <0x40000000 0x10000000>;
> +               reg = <0x40000000 0x20000000>;
> +       };

Can you send this in a separate patch? It should go into the tree now.

> +
> +       reserved-memory {
> +               #address-cells = <1>;
> +               #size-cells= <1>;
> +               ranges;
> +
> +               flash_mem: region at 52000000 {
> +                       compatible = "aspeed,lpc-ctrl";
> +                       no-map;
> +                       reg = <0x54000000 0x04000000>; /* 64m */
> +               };
> +
> +               fb_mem: framebuffer at 5f000000 {
> +                       no-map;
> +                       reg = <0x5f000000 0x01000000>; /* 16m */
> +               };

This should be a separate patch too, which we can take straight away.

> +       };
> +
> +       flash_buffer {

It's convention to put the reg value after @ in the node name:

  flash_buffer at 1e789000

> +               compatible = "aspeed,lpc-ctrl";

Upstream demands we put the SoC in the compatible string

 aspeed,ast2400-lpc-ctrl.

> +               memory-region = <&flash_mem>;
> +               reg = <0x1e789000 8>;

Make the second cell be 0x8 for consistency.

>         };

> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -870,6 +870,12 @@
>                                 interrupts = <8>;
>                         };
>
> +                       mbox: mbox at 1e789200 {
> +                               compatible = "aspeed,mbox-host";

aspeed,ast2400-mbox-host

Not sure on the name here.

> +                               reg = <0x1e789200 0x5c>;
> +                               interrupts = <46>;
> +                       };
> +
>                         wdt1: wdt at 1e785000 {
>                                 compatible = "aspeed,ast2400-wdt";
>                                 reg = <0x1e785000 0x1c>;
> --
> 2.10.2
>
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc