[PATCH 2/2] i2c: aspeed: cleanup driver

Brendan Higgins brendanhiggins at google.com
Wed Aug 31 07:44:04 AEST 2016

Oh, and one more note: I moved out the eeprom quirk patch from this patch
set because I think it makes sense as a different submission upstream.

On Tue, Aug 30, 2016 at 11:59 AM Brendan Higgins <brendanhiggins at google.com>

> checkpatch seems to be upset about my device tree identifiers being
> undocumented; do we have a coordinated effort for this? I did not even see
> a directory for aspeed under arm.
> checkpatch is also asked about updating MAINTAINERS, but looks like it
> should be covered under existing line:
> F: drivers/*/*aspeed*
> Does it just ask this every time you add a file?
> changelog:
>  - Squashed driver commits as suggested by Joel
>  - Renamed a couple functions for consistency
>  - Fixed a couple style errors
> On Sun, Aug 28, 2016 at 10:35 PM Joel Stanley <joel at jms.id.au> wrote:
>> Hi Brendan,
>> On Sun, Aug 21, 2016 at 11:04 AM, Brendan Higgins
>> <brendanhiggins at google.com> wrote:
>> > Rewrote most of master IRQ handler, xfer functions, and error recovery.
>> > Minor refactor of probing functions. Added remove functions.
>> Thanks for the patch. The diff is quite noisy given you're deleting
>> lots of cruft from the vendor driver. It would be easier for us to
>> review if you send the patch that adds the driver from scratch.
>> One suggestion I did have is to rename the driver to use the aspeed_
>> prefix for all functions so that it matches the drivers that have
>> already gone upstream.
>> Given our goal is immediate upstream submission, how about you send a
>> complete patch that adds the driver to upstream (say 4.8-rc4?)? Send
>> it to the i2c lists and cc myself, jk at ozlabs.org, and andrew at aj.id.au.
>> I hope we can get this sent out for upstream review this week. Let me
>> know if there's anything I can do to help achieve that.
>> Cheers,
>> Joel
>> > ---
>> >  drivers/i2c/busses/i2c-aspeed.c | 932
>> ++++++++++++++--------------------------
>> >  1 file changed, 318 insertions(+), 614 deletions(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20160830/cbed44c8/attachment.html>

More information about the openbmc mailing list