Linux dev-4.7 tree: Request for testing

[Cédric Le Goater]

Gavin,

>>   net/faraday: Mask PHY interrupt with NCSI mode
>>   net/faraday: Disallow using reversed MAC address from hardware
>>   net/faraday: Avoid PHYSTS_CHG interrupt
> 
> I gave it a try on a palmetto and a ast2500 evb. Both boot fine but
> the evb dmesg is full of :  
>
> net_ratelimit: 299522 callbacks suppressed
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x203: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x250: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x203: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
> ftgmac100 1e660000.ethernet eth0: [ISR] = 0x203: PHYSTS_CHG
> 
> Below is a possible fix,

Does that look like a correct fix  ? 

Thanks,

C.

> Cheers,
> 
> C.
> 
> 
> From: Cédric Le Goater <clg at kaod.org>
> Subject: [PATCH] net/ftgmac100: raise PHY link sensor level
> Date: Mon, 22 Aug 2016 16:29:02 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Commit 5f5d3d87370f ("net/faraday: Avoid PHYSTS_CHG interrupt")
> lowered the sensivity of the PHY link by setting Bit#11 in the MAC
> Control Register. But this seems to generate bogus PHY interrupts on
> non NC-SI adapters :
> 
>     net_ratelimit: 299522 callbacks suppressed
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x203: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x250: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x203: PHYSTS_CHG
>     ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>     ...
> 
> Let's lower the sensivity only for NC-SI adapters.
> 
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>  drivers/net/ethernet/faraday/ftgmac100.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: linux-openbmc-4.7.git/drivers/net/ethernet/faraday/ftgmac100.c
> ===================================================================
> --- linux-openbmc-4.7.git.orig/drivers/net/ethernet/faraday/ftgmac100.c
> +++ linux-openbmc-4.7.git/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -215,7 +215,6 @@ static void ftgmac100_init_hw(struct ftg
>  				 FTGMAC100_MACCR_RXMAC_EN	| \
>  				 FTGMAC100_MACCR_FULLDUP	| \
>  				 FTGMAC100_MACCR_CRC_APD	| \
> -				 FTGMAC100_MACCR_PHY_LINK_LEVEL | \
>  				 FTGMAC100_MACCR_RX_RUNT	| \
>  				 FTGMAC100_MACCR_RX_BROADPKT)
>  
> @@ -223,6 +222,9 @@ static void ftgmac100_start_hw(struct ft
>  {
>  	int maccr = MACCR_ENABLE_ALL;
>  
> +	if (priv->use_ncsi)
> +		maccr |= FTGMAC100_MACCR_PHY_LINK_LEVEL;
> +
>  	switch (speed) {
>  	default:
>  	case 10:
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
>