[PATCH 0/2] i2c: aspeed: ready driver for upstream

Brendan Higgins brendanhiggins at google.com
Sun Aug 21 11:34:16 AEST 2016

Did the cleanup of the i2c-aspeed driver. In the process, I found that the
EEPROM on the ast2500 evbs does not do ACK polling properly after a dummy write
before a read; so I added a quirk for that in the at24 EEPROM driver. It appears
that this problem was not apparent before because the driver took longer to
perform commands.

The goal of this patch set is to get the i2c-aspeed driver ready for upstream.
If you see any issues with the driver that would prevent upstreaming, please let
me know so I can fix it before the patch is applied.

I have tested my changes on the ast2500 evb, but not the ast2400 or any other

I have a TODO to add support for I2C protocol mangling: I added support for
sending stops between transfers (for the EEPROM quirk), but I did not yet add
support for any other types of I2C protocol mangling; I don't think that this
should cause any issues upstreaming, however.

I also have a change for i2c-core that I am working on for adding slave mode
support for SMBus Alert and I would like to use the i2c-aspeed driver and the
SSIF driver as the initial users of this new feature; I already mentioned this
to Wolfram Sang <wsa at the-dreams.de>.


More information about the openbmc mailing list