[PATCH skeleton 0/5] Remove custom org.openbmc.Object.ObjectMapper usage
Cyril Bur
cyrilbur at gmail.com
Mon Apr 18 10:43:03 AEST 2016
On Thu, 14 Apr 2016 11:00:50 -0500
OpenBMC Patches <openbmc-patches at stwcx.xyz> wrote:
Hi Brad,
The series looks good to me but I have a question that I keep asking and I'm
not sure I've ever seen a response.
Is it worth continuing to patch (and in this case cleanup) skeleton code? I was
under the impression that this wouldn't live on and that this was for bringup?
> <!-- Reviewable:start -->
> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/openbmc/skeleton/61)
> <!-- Reviewable:end -->
>
>
> https://github.com/openbmc/skeleton/pull/61
>
> Brad Bishop (5):
> Remove fan control support from Palmetto
> Add gitignore file
> Whitespace fixes for objects/*.c
> Fix compiler warnings for objects/*
> Remove custom org.openbmc.Object.ObjectMapper
>
> .gitignore | 6 +
> Makefile | 28 +-
> bin/Palmetto.py | 7 -
> bin/system_manager.py | 4 +-
> includes/object_mapper.c | 31 --
> includes/object_mapper.h | 10 -
> includes/openbmc.h | 2 +-
> objects/board_vpd_obj.c | 119 ++---
> objects/button_power_obj.c | 345 ++++++------
> objects/button_reset_obj.c | 180 +++----
> objects/control_bmc_barreleye.c | 496 +++++++++--------
> objects/control_bmc_obj.c | 445 ++++++++--------
> objects/control_host_obj.c | 540 +++++++++----------
> objects/fan_generic_obj.c | 263 +++++----
> objects/flash_bios_obj.c | 838 ++++++++++++++---------------
> objects/flasher_obj.c | 877 +++++++++++++++---------------
> objects/host_watchdog_obj.c | 365 +++++++------
> objects/hwmons_barreleye.c | 433 ++++++++-------
> objects/hwmons_palmetto.c | 422 +++++++--------
> objects/led_controller.c | 1124 ++++++++++++++++++++-------------------
> objects/pcie_slot_present_obj.c | 327 ++++++------
> objects/power_control_obj.c | 633 +++++++++++-----------
> 22 files changed, 3656 insertions(+), 3839 deletions(-)
> create mode 100644 .gitignore
> delete mode 100644 includes/object_mapper.c
> delete mode 100644 includes/object_mapper.h
> mode change 100755 => 100644 objects/button_reset_obj.c
> mode change 100755 => 100644 objects/control_host_obj.c
> mode change 100755 => 100644 objects/led_controller.c
>
More information about the openbmc
mailing list