[PATCH phosphor-host-ipmid 1/4] Add App Set BMC Global Enables ipmi cmd

[Patrick Williams]

This commit looks fine, but can you put it into a pull request on its
own?  Some of the other commits in this pull request have issues.

On Tue, Oct 20, 2015 at 10:23:26PM -0500, OpenBMC Patches wrote:
> From: Adriana Kobylak <anoo at us.ibm.com>
> 
> ---
>  apphandler.C | 17 +++++++++++++++++
>  apphandler.h | 16 ++++++++--------
>  2 files changed, 25 insertions(+), 8 deletions(-)
> 
> diff --git a/apphandler.C b/apphandler.C
> index 9d53552..132f5c6 100755
> --- a/apphandler.C
> +++ b/apphandler.C
> @@ -188,7 +188,18 @@ ipmi_ret_t ipmi_app_reset_watchdog(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
>      return rc;
>  }
>  
> +ipmi_ret_t ipmi_app_set_bmc_global_enables(ipmi_netfn_t netfn, ipmi_cmd_t cmd,
> +                             ipmi_request_t request, ipmi_response_t response,
> +                             ipmi_data_len_t data_len, ipmi_context_t context)
> +{
> +    ipmi_ret_t rc = IPMI_CC_OK;
> +    *data_len = 0;
>  
> +    // Event and message logging enabled by default so return for now
> +    printf("IPMI APP SET BMC GLOBAL ENABLES Ignoring for now\n");
> +
> +    return rc;
> +}
>  
>  
>  
> @@ -231,6 +242,12 @@ void register_netfn_app_functions()
>  
>      printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_READ_EVENT);
>      ipmi_register_callback(NETFUN_APP, IPMI_CMD_READ_EVENT, NULL, ipmi_app_read_event);
> +
> +    printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP,
> +                                            IPMI_CMD_SET_BMC_GLOBAL_ENABLES);
> +    ipmi_register_callback(NETFUN_APP, IPMI_CMD_SET_BMC_GLOBAL_ENABLES, NULL,
> +                                            ipmi_app_set_bmc_global_enables);
> +
>      return;
>  }
>  
> diff --git a/apphandler.h b/apphandler.h
> index 2c4ea22..3b8995c 100644
> --- a/apphandler.h
> +++ b/apphandler.h
> @@ -1,16 +1,16 @@
>  #ifndef __HOST_IPMI_APP_HANDLER_H__
>  #define __HOST_IPMI_APP_HANDLER_H__
>  
> -// IPMI commands for net functions.
> +// IPMI commands for App net functions.
>  enum ipmi_netfn_app_cmds
>  {
> -    // Get capability bits
> -    IPMI_CMD_RESET_WD       = 0x22,
> -    IPMI_CMD_SET_WD         = 0x24,
> -    IPMI_CMD_GET_CAP_BIT    = 0x36,
> -    IPMI_CMD_GET_DEVICE_ID  = 0x00,
> -    IPMI_CMD_SET_ACPI       = 0x06,
> -    IPMI_CMD_READ_EVENT     = 0x35,
> +    IPMI_CMD_GET_DEVICE_ID          = 0x01,
> +    IPMI_CMD_SET_ACPI               = 0x06,
> +    IPMI_CMD_RESET_WD               = 0x22,
> +    IPMI_CMD_SET_WD                 = 0x24,
> +    IPMI_CMD_SET_BMC_GLOBAL_ENABLES = 0x2E,
> +    IPMI_CMD_READ_EVENT             = 0x35,
> +    IPMI_CMD_GET_CAP_BIT            = 0x36,
>  
>  };
>  
> -- 
> 2.6.0
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151021/e90435b8/attachment.sig>