[PATCH phosphor-host-ipmid] Add ipmi cc for invalid sensor

Patrick Williams patrick at stwcx.xyz
Thu Oct 22 13:41:53 AEDT 2015


On Wed, Oct 21, 2015 at 09:31:54PM -0500, OpenBMC Patches wrote:
> From: Chris Austen <austenc at us.ibm.com>
> 
> ---
>  ipmid-api.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ipmid-api.h b/ipmid-api.h
> index caf18e8..588dd24 100755
> --- a/ipmid-api.h
> +++ b/ipmid-api.h
> @@ -86,7 +86,9 @@ enum ipmi_return_codes
>  {
>      IPMI_CC_OK = 0x00,
>      IPMI_DCMI_CC_NO_ACTIVE_POWER_LIMIT = 0x80,
> -    IPMI_CC_INVALID = 0xC1
> +    IPMI_CC_INVALID = 0xC1,
> +    IPMI_CC_SENSOR_INVALID = 0xCB
> +
>  };
>  
>  #endif
> -- 
> 2.6.0
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

Merged as is because the DCMI one is already here, but we shouldn't need
to put all the CCs in this file.  Otherwise we break the purpose of
modularizing the handlers.  I would suggest that CCs go into the
relevant file for the particular handler that emits that CC.  Unless, we
want to take every single CC documented in the IPMI spec and put it
here.
-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151021/a24d2dbc/attachment-0001.sig>


More information about the openbmc mailing list