[PATCH openbmc 20/20] Adding IPMI Parser Library.

[Patrick Williams]

On Tue, Oct 20, 2015 at 02:19:58PM -0500, OpenBMC Patches wrote:
> From: Hariharasubramanian R <hramasub at in.ibm.com>
> 
> ---
>  .../ipmi-fru-parser/ipmi-fru-parser.bb                 | 18 ++++++++++++++++++
>  .../packagegroups/packagegroup-obmc-phosphor-apps.bb   |  1 +
>  2 files changed, 19 insertions(+)
>  create mode 100644 meta-phosphor/common/recipes-phosphor/ipmi-fru-parser/ipmi-fru-parser.bb
> 
> diff --git a/meta-phosphor/common/recipes-phosphor/ipmi-fru-parser/ipmi-fru-parser.bb b/meta-phosphor/common/recipes-phosphor/ipmi-fru-parser/ipmi-fru-parser.bb
> new file mode 100644
> index 0000000..02ff308
> --- /dev/null
> +++ b/meta-phosphor/common/recipes-phosphor/ipmi-fru-parser/ipmi-fru-parser.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "OpenBMC IPMI FRU Parser"
> +DESCRIPTION = "Parse the common/chassis/board/product areas of the FRU data into a VPD dictionary table."
> +HOMEPAGE = "https://github.com/openbmc/ipmi-fru-parser"
> +PR = "r1"
> +
> +inherit obmc-phosphor-license
> +inherit obmc-phosphor-sdbus-service
> +
> +SRC_URI += "git://github.com/hramasub/ipmi-fru-parser"

We need to get the code reviewed and merged into the main
ipmi-fru-parser repository.  We shouldn't point at personal forks for a
recipe.

> +
> +SRCREV = "e097f0cc58c64564ae059f9b02ecb574e4cbb666"

This will also likely need to be updated.

> +
> +S = "${WORKDIR}/git"
> +
> +do_install() {
> +        install -m 0755 -d ${D}${libdir}/ipmi
> +        install -m 0755 ${S}/*.so ${D}${libdir}/ipmi
> +}

Why do these get installed into a special directory instead of usr/lib?
We won't be able to link against it if it isn't in one of the standard
paths.

Where is the install directive for the header file(s)?

Can you add a 'make install' to your package instead?  I'm in the
process of updating the ipmid to be the same way.

> diff --git a/meta-phosphor/common/recipes-phosphor/packagegroups/packagegroup-obmc-phosphor-apps.bb b/meta-phosphor/common/recipes-phosphor/packagegroups/packagegroup-obmc-phosphor-apps.bb
> index 4dbcdd3..54e5655 100644
> --- a/meta-phosphor/common/recipes-phosphor/packagegroups/packagegroup-obmc-phosphor-apps.bb
> +++ b/meta-phosphor/common/recipes-phosphor/packagegroups/packagegroup-obmc-phosphor-apps.bb
> @@ -26,6 +26,7 @@ SUMMARY_packagegroup-obmc-phosphor-apps-extras = "Extra features"
>  RDEPENDS_packagegroup-obmc-phosphor-apps-extras = " \
>          rest-dbus \
>          host-ipmid \
> +        ipmi-fru-parser \

We should not be adding this to the list of required packages.  If it is
needed by host-ipmid in order to do fru parsing then it should be added
to the DEPENDS/RDEPENDS list in that recipe.

>          "
>  
>  SUMMARY_packagegroup-obmc-phosphor-apps-fan-mgmt = "Fan management support"
> -- 
> 2.6.0
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151020/ea379b4b/attachment.sig>