[PATCH ipmi-fru-parser v3 4/4] Format string change in sd_bus_message_append.

[Patrick Williams]

On Fri, Oct 16, 2015 at 07:37:49AM -0500, OpenBMC Patches wrote:
> From: Hariharasubramanian R <hramasub at in.ibm.com>
> 
> ---
>  frup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/frup.c b/frup.c
> index 9711645..ab58426 100644
> --- a/frup.c
> +++ b/frup.c
> @@ -803,13 +803,13 @@ parse_fru (const void* msgbuf, sd_bus_message* vpdtbl)
>    {
>      if (i==OPENBMC_VPD_KEY_CHASSIS_TYPE)
>      {
> -        sd_bus_message_append (vpdtbl, "sd", vpd_key_names[i], chassis_type);
> +        sd_bus_message_append (vpdtbl, "sy", vpd_key_names[i], chassis_type);
>          continue;
>      }
>  
>      if (i==OPENBMC_VPD_KEY_BOARD_MFG_DATE)
>      {
> -        sd_bus_message_append (vpdtbl, "sd", vpd_key_names[i], mfg_date_time);
> +        sd_bus_message_append (vpdtbl, "sa{y}", vpd_key_names[i], mfg_date_time);
>          continue;
>      }
>      
> -- 
> 2.6.0
> 
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

Here are some of the changes from my previous review, it looks like.  Go
ahead and merge these together:

    'git rebase --interactive HEAD~2'
    Change last 'pick' to a 'fixup'.

I don't think "date" should be a set of bytes.  We should parse dates into
ASCII ISO8601 strings.
-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151016/f3615305/attachment.sig>