[PATCH ipmi-fru-parser v3 1/4] Checking in the basic IPMI FRU Parser Library. Parser has just enough intelligence to parse Chassis, Board & Product info areas. No support for multi-record in this version. This parser is a stripped down version of the parser in the FreeIPMI distribution.

[Patrick Williams]

Please fix up the commit message to be properly formed.  It is extremely
long right now.  Below is a link to good practices [1].

On Fri, Oct 16, 2015 at 07:37:46AM -0500, OpenBMC Patches wrote:
> From: Hariharasubramanian R <hramasub at in.ibm.com>
> 
> ---
>  Makefile |  19 ++
>  frup.c   | 599 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 618 insertions(+)
>  create mode 100644 Makefile
>  create mode 100644 frup.c
> 
> diff --git a/Makefile b/Makefile
> new file mode 100644
> index 0000000..cf75af3
> --- /dev/null
> +++ b/Makefile
> @@ -0,0 +1,19 @@
> +CXX ?= $(CROSS_COMPILE)g++
> +
> +IPMI_FRU_PARSER_LIB = libifp.so
> +IPMI_FRU_PARSER_OBJS = frup.o
> +
> +INC_FLAGS += $(shell pkg-config --cflags --libs libsystemd) -I. -O2 --std=gnu++11
> +LIB_FLAGS += $(shell pkg-config  --libs libsystemd) -rdynamic
> +#IPMID_PATH ?= -DHOST_IPMI_LIB_PATH=\"/usr/lib/host-ipmid/\" 
> +
> +all: $(IPMI_FRU_PARSER_LIB)
> +
> +%.o: %.c
> +	$(CXX) -fpic -c $< $(CXXFLAGS) $(INC_FLAG) $(IPMID_PATH) -o $@
> +
> +$(IPMI_FRU_PARSER_LIB): $(IPMI_FRU_PARSER_OBJS)
> +	$(CXX) $^ -shared $(LDFLAGS) $(LIB_FLAGS) -o $@
> +
> +clean:
> +	rm -f $(IPMI_FRU_PARSER_OBJS) $(IPMI_FRU_PARSER_LIB)

Please clean up this makefile.  Looks like you copied it from the ipmid.
At least the commented out IPMID_PATH isn't needed.

[1] https://wiki.openstack.org/wiki/GitCommitMessages
-- 
Patrick Williams