[PATCH openbmc 3/4] phosphor-host-ipmid: refresh SRCREV

Patrick Williams patrick at stwcx.xyz
Fri Oct 16 23:22:46 AEDT 2015


On Fri, Oct 16, 2015 at 02:44:01PM +1030, Joel Stanley wrote:
> On Fri, Oct 16, 2015 at 8:24 AM, OpenBMC Patches <patches at stwcx.xyz> wrote:
> > From: Patrick Williams <patrick at stwcx.xyz>
> >
> > Also required updating dependencies and installed files.
> > ---
> >  .../common/recipes-phosphor/host-ipmid/host-ipmid.bb       | 14 +++++++++-----
> >  1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta-phosphor/common/recipes-phosphor/host-ipmid/host-ipmid.bb b/meta-phosphor/common/recipes-phosphor/host-ipmid/host-ipmid.bb
> > index 9741e61..5e7ad64 100644
> > --- a/meta-phosphor/common/recipes-phosphor/host-ipmid/host-ipmid.bb
> > +++ b/meta-phosphor/common/recipes-phosphor/host-ipmid/host-ipmid.bb
> 
> >  do_install() {
> > -        install -m 0755 -d ${D}${sbindir} ${D}${libdir} ${D}${libdir}/host-ipmid/
> > +        install -m 0755 -d ${D}${sbindir}
> >          install -m 0755 ${S}/ipmid ${D}${sbindir}/
> > -        install -m 0755 ${S}/libapphandler.so ${D}${libdir}/host-ipmid/
> > +
> > +        install -m 0755 -d ${D}${libdir}/host-ipmid
> > +        install -m 0755 ${S}/*.so ${D}${libdir}/host-ipmid/
> > +
> > +        install -m 0755 -d ${D}${includedir}/host-ipmid
> > +        install -m 0644 ${S}/ipmid-api.h ${D}${includedir}/host-ipmid/
> >  }
> 
> Should we be putting install rules such as these in the makefile
> instead? That way the programs are useful outside of the poky
> buildsystem.

Good point.  I will add a 'make install' to the makefile in the ipmid
package and then refactor this recipe with a follow up commit.

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151016/d714f6cb/attachment.sig>


More information about the openbmc mailing list