[PATCH phosphor-host-ipmid 3/4] Suport examining sensor records and calling dbus

[Joel Stanley]

Hey Chris,

On Fri, Oct 16, 2015 at 2:59 PM, Chris Austen <austenc at us.ibm.com> wrote:
> Thanks for the code reviews.  The questions about the files in tmp... I
> first put them there because there wasn't any dbus objects to to do anything
> with yet.  Norm has now provided those objects but since then I have found
> them pretty invaluable in debugging and building a system.  I hesitate to
> remove them since it is a great debug entry point.  Would you think it could
> be cleaner if I added ifdef's?Or maybe if I set an env flag?  They are
> pretty worth while.

Coo, for debugging that's a different story. I would simply print them
out though, perhaps hidden behind a verbose or debug flag.

We should decide how these tools are going to do their logging, and
adopt a common method. Jeremy has some logging code that we use for
opal-prd that backs into syslog; that would be a great start I think.

  https://github.com/open-power/skiboot/blob/master/external/opal-prd/opal-prd.c#L172

> You are right about the lack of consistency with the function and struct
> naming conventions.  I'll have to pick one and go with it.

It's something that we should nail down. I really like the kernel's
naming convention, as many open source developers are familiar with
it, and there are good tools for checking code and patches against it.
It would serve us well for C and C-like C++ code.

Cheers,

Joel