[PATCH phosphor-event v3 1/3] Add delete for error logs

[Patrick Williams]

On Tue, Nov 24, 2015 at 02:56:01PM +1100, Stewart Smith wrote:
> OpenBMC Patches <openbmc-patches at stwcx.xyz> writes:
> 
> > From: Chris Austen <austenc at us.ibm.com>
> >
> > This supports both deleting individual logs
> > and all logs
> > ---
> >  Makefile         |   1 +
> >  event_messaged.c | 175 +++++++++++++++++++++++++++++++------------------------
> >  list.c           |  75 ++++++++++++++++++++++++
> >  list.h           |  23 ++++++++
> 
> Don't invent a new linked list, we already have CCAN list, and the
> approvals to use it (we ship it in skiboot).
> 
> The CCAN list provides useful iterators and is inline with the
> structure, which is much more efficient.
> 
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

I agree.  In general the rest of the code was C++ so the STL is a valid
alternative as well.  Chris and I have previously discussed this and
we're going to leave as is for now and then refactor away the custom
list in the next few months.

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20151124/5d7f1a9b/attachment.sig>